Expose Nexus Endpoint on Nexus Info#2837
Open
Quinn-With-Two-Ns wants to merge 1 commit intotemporalio:masterfrom
Open
Expose Nexus Endpoint on Nexus Info#2837Quinn-With-Two-Ns wants to merge 1 commit intotemporalio:masterfrom
Quinn-With-Two-Ns wants to merge 1 commit intotemporalio:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d66016626e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Quinn-With-Two-Ns
force-pushed
the
issue-2836
branch
from
d660166 to
a0b11c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Expose the Nexus Endpoint to the SDK.
Why?
So the handler knows what endpoint the request originally came from for visibility and per endpoint encryption
Checklist
Closes
How was this tested:
closes: #2836
Note
Medium Risk
Adds a new method to a public interface and propagates additional request metadata through Nexus handling paths, which may affect implementers and any custom interceptors relying on
NexusOperationInfo.Overview
Exposes the Nexus request endpoint to SDK Nexus operation implementations by adding
getEndpoint()toNexusOperationInfoand threading theRequest.endpointvalue throughInternalNexusOperationContextandNexusInfoImplinto the interceptor/outbound context.Updates the test server to include
endpointon polled Nexus requests (start and cancel), and extendsNexusOperationInfoTestassertions to validate the endpoint is surfaced to handlers.Reviewed by Cursor Bugbot for commit a0b11c8. Bugbot is set up for automated code reviews on this repo. Configure here.